[Rpm-maint] [rpm-software-management/rpm] Convert main data structures in elfdeps to C++ (PR #3581)

Panu Matilainen notifications at github.com
Tue Feb 25 07:48:23 UTC 2025


@pmatilai commented on this pull request.



>  
-    if (skipSoname(soname))
+static void addSoDep(std::vector<std::string> & deps,
+		     const std::string & soname,
+		     const std::string & ver, const std::string & marker)
+{
+    if (skipSoname(soname.c_str()))

Oh yup, that's just an accidental leftove caused by "wrong" refactoring order - reordered the two relevant commits and voila the issue goes away :sweat_smile: Thanks for spotting.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3581#discussion_r1969162707
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3581/review/2639908978 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250224/6b944366/attachment.htm>


More information about the Rpm-maint mailing list