[Rpm-maint] [rpm-software-management/rpm] Fix signed vs unsigned comparisons (PR #3515)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -58,18 +58,21 @@ static char *base64_encode_block(const char *plaintext_in, int length_in, char *
 
 #define BASE64_DEFAULT_LINE_LENGTH 64
 
-char *rpmBase64Encode(const void *data, size_t len, int linelen)
+char *rpmBase64Encode(const void *data, size_t len, int linelen_)

Ew, don't change parameter names for internal tweaks, this makes the code mightily confusing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3515#pullrequestreview-2542381999
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3515/review/2542381999 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250110/f7b954c2/attachment.htm>