[Rpm-maint] [rpm-software-management/rpm] Add support for RPMKEYRING_MERGE (PR #3526)

[Neal H. Walfield]

@nwalfield commented on this pull request.



> @@ -23,7 +23,8 @@ extern "C" {
 typedef enum rpmKeyringModifyMode_e {
     RPMKEYRING_ADD	= 1,
     RPMKEYRING_REPLACE	= 2,
-    RPMKEYRING_DELETE	= 3
+    RPMKEYRING_DELETE	= 3,
+    RPMKEYRING_MERGE	= 4,

In terms of semantics, I'm happy that `MERGE` acts like `ADD` if the certificate is not present.

With respect to the documentation, I think it will prevent some bugs if we add a note that "add" and "replace" are almost never what the caller actually wants and they should always almost prefer "merge."  Perhaps add some examples of when one ought to use "add" or "replace".  (I can't think of any sensible ones, TBH.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3526#discussion_r1922107530
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3526/review/2561885728 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250120/89ca0c13/attachment.htm>