[Rpm-maint] [rpm-software-management/rpm] Add support for RPMKEYRING_MERGE (PR #3526)

Panu Matilainen notifications at github.com
Wed Jan 22 11:21:33 UTC 2025


@pmatilai commented on this pull request.



> @@ -133,7 +148,7 @@ int rpmKeyringModify(rpmKeyring keyring, rpmPubkey key, rpmKeyringModifyMode mod
 	if (item->second->fp == key->fp)
 	    break;
     }
-    if (item != range.second && (mode == RPMKEYRING_DELETE || mode == RPMKEYRING_REPLACE)) {
+    if (item != range.second) {

Hmm, guess not. The code just looks a bit weird.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3526#discussion_r1925152666
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3526/review/2566927788 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250122/ff92b62c/attachment.htm>


More information about the Rpm-maint mailing list