[Rpm-maint] [rpm-software-management/rpm] Run test-suite environment setup inside the image (PR #3531)
Michal Domonkos
notifications at github.com
Thu Jan 23 09:49:16 UTC 2025
> ... but basically, only do on the outside what has to be on the outside: copying data into the image.
Oh, indeed. You're right, I didn't realize this initially. We are copying stuff *from the host*, which is one way to draw the line, and I agree it's probably the most sensible :smile: Thanks for clarifying!
> I left the ldconfig stuff alone because it's kinda part of the "cmake install" step, but could certainly be moved to setup as well. If rpm shipped it's own ld.so.conf.d file, putting it into place would be necessarily part of install. But since we create it here, it can be either 😅
> [...]
> Hmm, but that said: ldconfig on the host might not be compatible with what's on the inside. So while putting the conf file in place can be considered install, running ldconfig should actually happen inside.
Yep, the ldconfig stuff wasn't necessarily what I had in mind, it was more about the various directories and whatnot that we copy/create, but I stand corrected, see above :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3531#issuecomment-2609349380
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3531/c2609349380 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250123/3c290780/attachment-0001.htm>
More information about the Rpm-maint
mailing list