[Rpm-maint] [rpm-software-management/rpm] Consistify and cleanup test-suite setup macros (PR #3535)

Panu Matilainen notifications at github.com
Fri Jan 24 09:34:27 UTC 2025


More details in commits but addressing various items from #2773:
- rename RPMTEST_SETUP to RPMTEST_INIT to free the name
- introduce RPMTEST_SETUP as a wrapper to AT_SETUP and use it everywhere, to pair with RPMTEST_CLEANUP and gives a central place to control rpm-specifics of test setup
- remove now redundant rpmdb reinitializations from the test by making rpmdb reset explicitly called when absolutely needed

Besides making for more consistent names and allowing future consolidation, gives a nice speed boost (from 2m 50s to 2m 20s on my laptop)

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3535

-- Commit Summary --

  * Rename RPMTEST_SETUP to RPMTEST_INIT to make room for manouvering
  * Add RPMTEST_SETUP as a wrapper for AT_SETUP and use it in all tests
  * Split testsuite rpmdb reset to a macro of its own
  * Explicitly separate test-suite rpmdb reset from test initialization

-- File Changes --

    M tests/README.md (4)
    M tests/local.at (14)
    M tests/rpmbrp.at (2)
    M tests/rpmbuild.at (434)
    M tests/rpmbuildid.at (72)
    M tests/rpmconfig.at (85)
    M tests/rpmconfig2.at (72)
    M tests/rpmconfig3.at (30)
    M tests/rpmconflict.at (72)
    M tests/rpmdb.at (94)
    M tests/rpmdeps.at (150)
    M tests/rpmdevel.at (6)
    M tests/rpme.at (50)
    M tests/rpmgeneral.at (26)
    M tests/rpmi.at (292)
    M tests/rpmio.at (16)
    M tests/rpmmacro.at (182)
    M tests/rpmorder.at (12)
    M tests/rpmpgp.at (4)
    M tests/rpmpkgfmt.at (14)
    M tests/rpmpython.at (10)
    M tests/rpmquery.at (182)
    M tests/rpmreplace.at (76)
    M tests/rpmscript.at (43)
    M tests/rpmsigdig.at (180)
    M tests/rpmspec.at (38)
    M tests/rpmvercmp.at (2)
    M tests/rpmverify.at (82)
    M tests/rpmvfylevel.at (20)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3535.patch
https://github.com/rpm-software-management/rpm/pull/3535.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3535
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3535 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250124/e598f938/attachment-0001.htm>


More information about the Rpm-maint mailing list