[Rpm-maint] [rpm-software-management/rpm] Check not configured keystore backends for keys (PR #3539)

[Panu Matilainen]

@pmatilai commented on this pull request.



>  };
 
 class keystore_fs : public keystore {
 public:
     virtual rpmRC load_keys(rpmtxn txn, rpmKeyring keyring);
     virtual rpmRC import_key(rpmtxn txn, rpmPubkey key, int replace = 1, rpmFlags flags = 0);
     virtual rpmRC delete_key(rpmtxn txn, rpmPubkey key);
-
+    keystore_fs(std::string n="fs"): keystore(n) {};

Don't use a default argument, we don't want anybody calling eg the "fs" keystore with "rpmdb" as the name, ever. Just hardcode the name into the keystore constructor call.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3539#pullrequestreview-2575225059
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3539/review/2575225059 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250127/1c10c655/attachment-0001.htm>