[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for explicit RPMTEST_INIT (PR #3542)
Panu Matilainen
notifications at github.com
Wed Jan 29 07:59:57 UTC 2025
@pmatilai commented on this pull request.
> @@ -135,10 +135,10 @@ For the typical structure of a single test, consult GNU Autotest's
[documentation](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/autoconf.html#Writing-Testsuites)
as well as the existing tests. Below are the specifics of RPM's test-suite:
-* Use `RPMTEST_SETUP` instead of `AT_SETUP`
-* Use `RPMTEST_CHECK` instead of `AT_CHECK`
-* Use `RPMTEST_CLEANUP` instead of `AT_CLEANUP`
-* Use `RPMTEST_INIT` to create a mutable snapshot (optional)
+* Use `RPMTEST_SETUP` instead of `AT_SETUP` to run a test in an immutable
+ system image with writable `.` and `/tmp`.
+* Use `RPMTEST_SETUP_RW` instead of `AT_SETUP` to run a test in a mutable
> If your test needs to alter the root filesystem (e.g. to install a package), use RPMTEST_SETUP_RW instead to request a mutable snapshot of the filesystem.
BTW this describes more the situation where we would like to be than the current reality: one needs RW just to *build* a package and other similar silliness, just because of how things are set up (it made sense 15 years ago but the world has moved on :smile: )
But, I'll take another look at the docs - I knew it was rough and tried to get away with bare minimum, appropriately caught here :laughing:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3542#discussion_r1933412615
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3542/review/2580255753 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250128/58c19510/attachment.htm>
More information about the Rpm-maint
mailing list