[Rpm-maint] [rpm-software-management/rpm] Check not configured keystore backends for keys (PR #3539)

Panu Matilainen notifications at github.com
Wed Jan 29 08:09:04 UTC 2025


@pmatilai commented on this pull request.



> @@ -71,6 +71,20 @@ rpmKeyring rpmKeyringFree(rpmKeyring keyring)
     return NULL;
 }
 
+size_t rpmKeyringSize(rpmKeyring keyring, rpmFlags flags)
+{
+    assert(flags == 0);

BTW this is a pretty antisocial way to validate flags, we don't really do this.

Are you visioning other flags besides counting only primary vs including subkeys? If it's just a boolean (zero vs nonzero) then we wouldn't even need to validate it really.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3539#pullrequestreview-2580274681
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3539/review/2580274681 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250129/a42e4307/attachment-0001.htm>


More information about the Rpm-maint mailing list