[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for explicit RPMTEST_INIT (PR #3542)

[Michal Domonkos]

@dmnks commented on this pull request.



> @@ -135,10 +135,10 @@ For the typical structure of a single test, consult GNU Autotest's
 [documentation](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/autoconf.html#Writing-Testsuites)
 as well as the existing tests.  Below are the specifics of RPM's test-suite:
 
-* Use `RPMTEST_SETUP` instead of `AT_SETUP`
-* Use `RPMTEST_CHECK` instead of `AT_CHECK`
-* Use `RPMTEST_CLEANUP` instead of `AT_CLEANUP`
-* Use `RPMTEST_INIT` to create a mutable snapshot (optional)
+* Use `RPMTEST_SETUP` instead of `AT_SETUP` to run a test in an immutable
+  system image with writable `.` and `/tmp`.
+* Use `RPMTEST_SETUP_RW` instead of `AT_SETUP` to run a test in a mutable

> Maybe it's enough to say "RPMTEST_SETUP_RW instead to prepare the use of a mutable snapshot", followed by the bullet list on how to actually run stuff there.

Oh yup, "prepare" sounds good to me, too, it's even better.

> Except that ... runroot() and runroot_other() are getting incredibly pointless in this picture. We should hide that part into RPMTEST_CHECK() really, similarly to how we're fading the other bits into RPMTEST_SETUP* here. But that's a PR for another time 🙈

Yep, I agree that's kinda the end goal here. We want this to be fully transparent to the user writing a test. The user should just call "rpm" etc. normally, without remembering to use "runroot" etc. (also see #2773).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3542#discussion_r1933425855
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3542/review/2580276373 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250129/5aa03c86/attachment.htm>