[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for explicit RPMTEST_INIT (PR #3542)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -135,10 +135,10 @@ For the typical structure of a single test, consult GNU Autotest's
 [documentation](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/autoconf.html#Writing-Testsuites)
 as well as the existing tests.  Below are the specifics of RPM's test-suite:
 
-* Use `RPMTEST_SETUP` instead of `AT_SETUP`
-* Use `RPMTEST_CHECK` instead of `AT_CHECK`
-* Use `RPMTEST_CLEANUP` instead of `AT_CLEANUP`
-* Use `RPMTEST_INIT` to create a mutable snapshot (optional)
+* Use `RPMTEST_SETUP` instead of `AT_SETUP` to run a test in an immutable
+  system image with writable `.` and `/tmp`.
+* Use `RPMTEST_SETUP_RW` instead of `AT_SETUP` to run a test in a mutable

The test author needs to be aware of where stuff runs of course, but the inside/outside difference is largely a historical remnant. For most test, there's no need for them to be aware of the "outside" anymore, and also most tests using runroot do so for all of their commands. So it might be just as well wrapped on the RPMTEST_CHECK() level (eg with RPMTEST_CHECK_RW()) 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3542#discussion_r1933447924
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3542/review/2580310943 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250129/0c0f48a9/attachment-0001.htm>