[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for explicit RPMTEST_INIT (PR #3542)

[Michal Domonkos]

@dmnks commented on this pull request.



> @@ -135,10 +135,10 @@ For the typical structure of a single test, consult GNU Autotest's
 [documentation](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/autoconf.html#Writing-Testsuites)
 as well as the existing tests.  Below are the specifics of RPM's test-suite:
 
-* Use `RPMTEST_SETUP` instead of `AT_SETUP`
-* Use `RPMTEST_CHECK` instead of `AT_CHECK`
-* Use `RPMTEST_CLEANUP` instead of `AT_CLEANUP`
-* Use `RPMTEST_INIT` to create a mutable snapshot (optional)
+* Use `RPMTEST_SETUP` instead of `AT_SETUP` to run a test in an immutable
+  system image with writable `.` and `/tmp`.
+* Use `RPMTEST_SETUP_RW` instead of `AT_SETUP` to run a test in a mutable

What you mean is basically run the whole of `RPMTEST_CHECK()` *inside* the snapshot (if enabled with `RPMTEST_SETUP_RW`). Yes, that would simplify things conceptually, but would remove the ability to inspect and/or verify the results of a test from outside, like said, plus might turn out to be challening since a lot of the current rpmtests logic relies on this separation.

Anything in between is just obfuscating the fact that there *is* a split, I'm afraid :sweat_smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3542#discussion_r1933463168
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3542/review/2580335447 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250129/300f7ffb/attachment.htm>