[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for explicit RPMTEST_INIT (PR #3542)
Michal Domonkos
notifications at github.com
Wed Jan 29 08:43:31 UTC 2025
@dmnks commented on this pull request.
> @@ -135,10 +135,10 @@ For the typical structure of a single test, consult GNU Autotest's
[documentation](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/autoconf.html#Writing-Testsuites)
as well as the existing tests. Below are the specifics of RPM's test-suite:
-* Use `RPMTEST_SETUP` instead of `AT_SETUP`
-* Use `RPMTEST_CHECK` instead of `AT_CHECK`
-* Use `RPMTEST_CLEANUP` instead of `AT_CLEANUP`
-* Use `RPMTEST_INIT` to create a mutable snapshot (optional)
+* Use `RPMTEST_SETUP` instead of `AT_SETUP` to run a test in an immutable
+ system image with writable `.` and `/tmp`.
+* Use `RPMTEST_SETUP_RW` instead of `AT_SETUP` to run a test in a mutable
So... thinking about it more, yep, no point in optimizing for this theoretical one or two tests when the majority of them are fine without the separation. In that case, just running the whole test script in the snapshot container might just be the best thing. But this is indeed for a separate PR/discussion so I'll shut up now :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3542#discussion_r1933471343
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3542/review/2580348338 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250129/9c8ddc97/attachment.htm>
More information about the Rpm-maint
mailing list