[Rpm-maint] [rpm-software-management/rpm] Ensure tests/setup.sh is only ever run inside the test-image (PR #3552)

[Michal Domonkos]

@dmnks requested changes on this pull request.



>  
-mkdir -p $DESTDIR/build
-ln -sf ../data/SOURCES $DESTDIR/build/
+# Make sure nobody runs this accidentally outside the environment
+if [ ! /.rpmtestsuite ]; then

Oops, this is missing an `-f`. Without it, the conditional is always false (i.e. the file isn't actually required to exist) :sweat_smile:

It's funny because this is the kind of thing that you just don't want to test locally :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3552#pullrequestreview-2587163374
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3552/review/2587163374 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250131/9cd9a1e9/attachment.htm>