[Rpm-maint] [rpm-software-management/rpm] Don't print empty return of --eval macro expansion (PR #3804)

Paul Bolle notifications at github.com
Fri Jun 13 10:40:18 UTC 2025


pebolle left a comment (rpm-software-management/rpm#3804)

> The comment about Lua is misleading, this covers and affects all macros.

True. (It is silly that I painstakingly edited a dozen or so tests in which some macros expanded to an empty string without realizing that my original motivation to suggest this change was too narrow!) 

> It's a good change technically, those empty lines can drive one nuts.

Glad to hear its not just me!

> The question is whether we dare to make it, because this is 20+ year old behavior and who knows what depends on that exact behavior. Basically there's no way to find out, expect by trying it. I think we should try.

> If you update the comment I'll merge, just with an understanding that there is a chance we have to back out of it if it breaks the world.

Feel free to blame me if that happens. And thanks for your feedback.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3804#issuecomment-2969910454
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3804/c2969910454 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250613/4f3f0e2c/attachment.htm>


More information about the Rpm-maint mailing list