[Rpm-maint] [rpm-software-management/rpm] Add test for multifile sort order (PR #3825)

Michal Domonkos notifications at github.com
Fri Jun 20 15:22:22 UTC 2025


Commit bc0b94026bc5651435819043394cbe9a766a4fd5 made sure filenames fed to multifile generators are always sorted in ascending order. The order was previously undefined because the hashmap being populated by parallel threads.

Test this with a custom generator that produces a single dependency based on the very first filename it gets on input, similarly to the original use case described in the above commit.

Note that there's a (very tiny) chance that the threads would end up in the "good" order by accident and thus a regression in the sorting logic wouldn't be caught. Reduce that chance to a minimum by simply running rpmdeps 10 times in a row, that should give us more than enough confidence.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3825

-- Commit Summary --

  * Add test for multifile sort order

-- File Changes --

    M tests/rpmbuild.at (29)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3825.patch
https://github.com/rpm-software-management/rpm/pull/3825.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3825
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3825 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250620/13ddfa9b/attachment.htm>


More information about the Rpm-maint mailing list