[Rpm-maint] [rpm-software-management/rpm] Drop irrepairable pkgid and hdrid tag aliases, rename SOURCEPKGID to go (PR #3831)

[Panu Matilainen]

RPMTAG_PKGID and RPMTAG_HDRID are nothing but #define'd aliases to MD5 and SHA1 signature header tags, neither of which exists in v6 packages. If these were standalone tags we could adjust the content, but as it is we cannot continue to produce these obsolete digests forever, and we cannot change their content to anything else because that would in turn break v4 compat for the sake of couple of obscure tags.

RPMTAG_SOURCEPKGID is a standalone tag but where it exists, its contents are tied to SIGMD5, a tag v6 packages do not have. So we'll just rename it to match the content.

Like the PAYLOADDIGEST rename in f14557cd521ddf95994aa6518f006eeb3fc58d87, this is fully binary compatible but it is a break in the API and cli queries: any users will need to be aware of this change and update their code accordingly. And like in that case, it's useful to learn if anybody actually relies on this stuff.

Fixes: #3330
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3831

-- Commit Summary --

  * Drop irrepairable pkgid and hdrid tag aliases, rename SOURCEPKGID to go

-- File Changes --

    M build/pack.cc (2)
    M include/rpm/rpmtag.h (4)
    M lib/tagname.cc (3)
    M tests/data/misc/rpmdump4.txt (2)
    M tests/rpmgeneral.at (4)
    M tests/rpmpkgfmt.at (20)
    M tests/rpmquery.at (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3831.patch
https://github.com/rpm-software-management/rpm/pull/3831.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3831
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3831 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250624/6325aa00/attachment.htm>