[Rpm-maint] [rpm-software-management/rpm] Fail package install/erase on %triggerprein/%triggerun failure (PR #3834)

Panu Matilainen notifications at github.com
Wed Jun 25 08:05:46 UTC 2025


%triggerprein and %triggerun are "pre" scriptlets that occur before package install and uninstall, respectively. We fail the install/erase on other such pre-scriptlets, so for consistency's sake it seems we should do so for these as well.

File triggers are too asymmetric to have sane failure modes for pre-thingies so we leave them alone here. Unfortunately file triggers don't have scriptlet types of their own and can't afford to stop for a big refactor just now, so manually filter them out in rpmScriptFromTriggerTag().

Fixes: #3815
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3834

-- Commit Summary --

  * Fail package install/erase on %triggerprein/%triggerun failure

-- File Changes --

    M lib/rpmscript.cc (7)
    M tests/rpmscript.at (28)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3834.patch
https://github.com/rpm-software-management/rpm/pull/3834.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3834
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3834 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250625/4037c0d9/attachment-0001.htm>


More information about the Rpm-maint mailing list