[Rpm-maint] [rpm-software-management/rpm] Move ~/.rpmmacros and ~/.rpmrc to ~/.config/rpm/ (PR #3750)
Panu Matilainen
notifications at github.com
Fri Jun 27 07:38:32 UTC 2025
pmatilai left a comment (rpm-software-management/rpm#3750)
There are a few cosmetic items left still that could be addressed within a day but:
I'm not going to merge a change this disruptive on the eve of the beta, stuff like this needs some real-world soak-time in our own use before unleashing to users (see the above remark on the situations where this may run). We can still merge it afterwards for that soak-time and then tweak as necessary and finally (re)consider whether we can ship it as-is as late as beta2.
The file-level logistics of this seem fine now, on a quick glance. It looked okay on the previous round too though, so I'm goint to have some hands-on time with this.
The biggest issue with this whole thing is the late realization (from the man page update) that as-is, this would run on anything loading initializing the rpm library. Which can run in all manner of very wild contexts, including but not limited to cgi-scripts in parallel and who knows what. I think we need to find a way to contain this to only rpm commands - of those we at least have a reasonable idea how and where they are commonly executed.
Another realization from last evening is that the "root issue" is somewhat more subtle: it's not that we could never migrate root's files, it's that we can't let root migrate other users files. So basically we'd need to verify the uid's of the files we're about to move. No *need* to do that here, just a general remark that we could lift the root restriction by doing so, in a later patch perhaps.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3750#issuecomment-3012030324
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3750/c3012030324 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250627/1b0f346a/attachment.htm>
More information about the Rpm-maint
mailing list