[Rpm-maint] [rpm-software-management/rpm] Fix verify element sorting (PR #4043)

Panu Matilainen notifications at github.com
Fri Nov 14 09:22:50 UTC 2025


This fixes the silly and innocent looking copy-paste error that is #1057 , but which was masking various logic errors in the verification code. With the verify logic fixed in #4020, this becomes the exercise in adjusting test-results order that it ought to be.

The first commit is for another verification logic error in signing code, actual fix is split into two commits for review convenience, but would  probably make more sense as a single commit for merging.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/4043

-- Commit Summary --

  * Don't assume all digests we look for can be found during signing
  * Fix verify element sorting for signature algorithms
  * Fix verify element sorting for hash algorithms

-- File Changes --

    M lib/rpmvs.cc (4)
    M sign/rpmgensig.cc (4)
    M tests/rpmsigdig.at (164)
    M tests/rpmvfylevel.at (16)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/4043.patch
https://github.com/rpm-software-management/rpm/pull/4043.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4043
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4043 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20251114/edcfcea6/attachment.htm>


More information about the Rpm-maint mailing list