[Rpm-maint] [rpm-software-management/rpm] AIX: revert xsetprogname and xgetprogname (PR #4056)

[Panu Matilainen]

pmatilai left a comment (rpm-software-management/rpm#4056)

Hmm. The idea of reviving the original assumed the original implementation made sense, but it doesn't, really. Which must've contributed to it getting deleted.

Thing is, this is an incredibly fiddly and fragile tangle of ifdefs and weird symbols scattered around, and impossible to test outside some specific platform that doesn't match the previous tangle of stuff. 

The sane way to do such portability wrappers is to have proper functions that are always compiled on all platforms, and then handle *all* the platform specifics inside that one source file, and provide them in the public API. For rpm this would mean something like rgetprogname() and rsetprogname() in librpmio. include/rpm/rpmutil.h is a fine place for these. And none of these weird _rpmxgrubfargh stuff :smile: It'll also make system.h smaller, which is always a good sign.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4056#issuecomment-3588665680
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4056/c3588665680 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20251128/bb0c059d/attachment.htm>