[Rpm-maint] [rpm-software-management/rpm] Fix "--restore --all" regression when the rpmdb contains gpg-pubkey h… (PR #3914)

[Panu Matilainen]

…eaders

The extra checks added in cf78319c5883453b9641d325402e35f6c8a73d78 cause rpmtsAddRestoreElement() to fail on gpg-pubkey headers. There's nothing to restore in them, so lets just silently skip them instead.

Also add an error message for the case. Had such message been there, the ticket would've appeared far less mysterious to begin with.

Add a testcase for --restore --all to catch this, previously we were only testing an explicit named restore. Alas, there doesn't seem to be a way to test the error message as that'd require a corrupt package in the rpmdb now that the gpg-pubkey loophole is plugged.

Fixes: #3904
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3914

-- Commit Summary --

  * Fix "--restore --all" regression when the rpmdb contains gpg-pubkey headers

-- File Changes --

    M lib/rpminstall.cc (14)
    M tests/rpmverify.at (25)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3914.patch
https://github.com/rpm-software-management/rpm/pull/3914.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3914
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3914 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250901/69c0ac3b/attachment.htm>