[Rpm-maint] [rpm-software-management/rpm] Use .cpio suffix for cpio output files (PR #3937)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -216,11 +216,21 @@ static int process_package(rpmts ts, const char * filename)
 	} else {
 	    outname = rstrscat(NULL, filename, NULL);
 	}
-	if (compress) {
-	    outname = rstrscat(&outname, ".tgz", NULL);
-	} else {
-	    outname = rstrscat(&outname, ".tar", NULL);
+
+	if (rstreq(format, "pax")) {
+	    if (compress) {
+		outname = rstrscat(&outname, ".tgz", NULL);
+	    } else {
+		outname = rstrscat(&outname, ".tar", NULL);
+	    }
+	} else if (rstreq(format, "cpio")) {
+	    if (compress) {
+		outname = rstrscat(&outname, ".cpio.gz", NULL);

I wonder if this should be .cgz for consistency with .tgz. Or, change .tgz to .tar.gz, but that might break somebody's scripts...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3937#pullrequestreview-3214745462
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3937/review/3214745462 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250911/f6e1ec5f/attachment-0001.htm>