[Rpm-maint] [rpm-software-management/rpm] Specify overridden member functions as `override` (PR #3948)
Piotr Idzik
notifications at github.com
Tue Sep 16 19:18:09 UTC 2025
[Virtual functions should specify exactly one of `virtual`, `override`, or `final`](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c128-virtual-functions-should-specify-exactly-one-of-virtual-override-or-final). In this case, they all could be marked as `final`, but this is a design decision and I do not want to take it here.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/3948
-- Commit Summary --
* Specify overridden member functions as `override`
-- File Changes --
M lib/keystore.hh (24)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/3948.patch
https://github.com/rpm-software-management/rpm/pull/3948.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3948
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3948 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250916/d5553a4f/attachment-0001.htm>
More information about the Rpm-maint
mailing list