[Rpm-maint] [rpm-software-management/rpm] `rpmfcFileDep::operator<` should be `const` (PR #3951)

[Piotr Idzik]

vil02 left a comment (rpm-software-management/rpm#3951)

@pmatilai: my intentions are the following. I decided to run `clang-tidy`: the amount of warnings it generates on this project is intimidating. I wanted to fix few of them - and yes, I know that `clang-tidy` is not part of the CI etc. - it is always easier to use such tools when the number of warnings is small. I decided to start with the easy ones first:
- this change resolved all of the [`readability-make-member-function-const`](https://clang.llvm.org/extra/clang-tidy/checks/readability/make-member-function-const.html) warnings,
- #3950 resolved all of [`readability-duplicate-include`](https://clang.llvm.org/extra/clang-tidy/checks/readability/duplicate-include.html) warnings,
- #3952 was supposed to resolve all of the [`readability-delete-null-pointer`](https://clang.llvm.org/extra/clang-tidy/checks/readability/delete-null-pointer.html).

Although all of the changes above are really trivial, they resolve all of the warnings of given type. In other words: they _add value_ - it is slightly easier to use `clang-tidy` on this project now.

I wanted to keep these changes separate as they are easier to review. So that is it. I certainly did not want to create too much noise or distraction.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3951#issuecomment-3309095389
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3951/c3309095389 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250918/ca34961a/attachment.htm>