[Rpm-maint] [rpm-software-management/rpm] Refactor rpmds internals to use STL vectors and strings instead of C dynamic allocations (PR #3953)

[Michal Domonkos]

@dmnks commented on this pull request.



>  
-	ds->EVR = xrealloc(ds->EVR, (ds->Count+1) * sizeof(*ds->EVR));
-	if (u < ds->Count) {
-	    memmove(ds->EVR + u + 1, ds->EVR + u,
-		    (ds->Count - u) * sizeof(*ds->EVR));
-	}
-	OEVR = rpmdsEVR(ods);

`OEVR` is dropped from the new code. I guess it was some kind of RPM 3.x compat thingy that's no longer needed, right? In that case, shouldn't it be mentioned in the commit message, too?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3953#pullrequestreview-3279470389
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3953/review/3279470389 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250929/69001fe1/attachment.htm>