[Rpm-maint] [rpm-software-management/rpm] Refactor rpmds internals to use STL vectors and strings instead of C dynamic allocations (PR #3953)

Michal Domonkos notifications at github.com
Mon Sep 29 12:19:45 UTC 2025


@dmnks commented on this pull request.



>  
-	ds->EVR = xrealloc(ds->EVR, (ds->Count+1) * sizeof(*ds->EVR));
-	if (u < ds->Count) {
-	    memmove(ds->EVR + u + 1, ds->EVR + u,
-		    (ds->Count - u) * sizeof(*ds->EVR));
-	}
-	OEVR = rpmdsEVR(ods);

Argh, what I meant by `OEVR` here was the check whether it's `NULL` and if so, the empty string would be inserted.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3953#discussion_r2387740555
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3953/review/3279476969 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250929/d19703ed/attachment.htm>


More information about the Rpm-maint mailing list