[Rpm-maint] [rpm-software-management/rpm] Refactor rpmds internals to use STL vectors and strings instead of C dynamic allocations (PR #3953)

[Panu Matilainen]

@pmatilai commented on this pull request.



>  
-	ds->EVR = xrealloc(ds->EVR, (ds->Count+1) * sizeof(*ds->EVR));
-	if (u < ds->Count) {
-	    memmove(ds->EVR + u + 1, ds->EVR + u,
-		    (ds->Count - u) * sizeof(*ds->EVR));
-	}
-	OEVR = rpmdsEVR(ods);

I wish you'd asked me this two weeks ago while I still had the context in memory :sweat_smile: 

*scratches head*

So this relates to that other rpmds PR as well, in particular: b3b87f803ccb095b68ac660df9df43dcf0290b4e
...which means the NULL cannot happen anymore. At least so the theory goes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3953#discussion_r2387884994
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3953/review/3279702982 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250929/8c0d8101/attachment.htm>