[Rpm-maint] [rpm-software-management/rpm] Implement one-shot macro modifier <o> (PR #4169)

[Michal Domonkos]

@dmnks commented on this pull request.



> @@ -724,7 +734,12 @@ doDefine(rpmMacroBuf mb, const std::string & str, int level, int expandbody, siz
     }
 
     /* Check for modifier compatibility */
-    if (o && (flags & ME_LITERAL)) {
+    if (o && (flags & (ME_LITERAL|ME_ONESHOT))) {
+	rpmMacroBufErr(mb, 1, _("Macro %%%s has incompatible modifiers\n"), n);

Oh yup, trying to come up with a consistent message is indeed quite hard in this case :sweat_smile: 
Some other (shorter) ideas:

- "Macro %s is parametric with incompatible modifiers"
- "Macro %s has incompatible parameters and modifiers"

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4169?email_source=notifications&email_token=ADLPZU5GERF7TZESTXRKSO34WXNVVA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJTHAZTSNJUGAZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3109258942
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4169/review/4138395403 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260420/68ed7749/attachment.htm>