[Rpm-maint] [rpm-software-management/rpm] Implement one-shot macro modifier <o> (PR #4169)
Michal Domonkos
notifications at github.com
Mon Apr 20 08:48:48 UTC 2026
@dmnks commented on this pull request.
> @@ -292,8 +302,11 @@ callee(s).
To define a global macro inside a parametric macro, you _must_ use *%global*
instead of *%define*. Also note that because such a macro may be referring
-to other macros only visible in the current scope, *%global* _expands the
-macro body once at the time of definition_, unless it's a *l*iteral macro.
+to other macros only visible in the current scope, *%global* expands the
+macro body once at the time of definition, unless it's a *l*iteral macro.
+Note that the body of a *o*ne-shot macro defined via *%global* is actually
If we're going to keep the ability to define a one-shot, global macro, the last sentence here should probably go elsewhere (to the paragraph about one-shot macros, or %global perhaps) since it's too easy to miss this detail. It also doesn't seem to belong to "Scope and visibility", I feel like...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4169?email_source=notifications&email_token=ADLPZUYVP2NMJVPYQ7HVSZD4WXP7BA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJTHA2TGOBWGU3KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#pullrequestreview-4138538656
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4169/review/4138538656 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260420/523e4e3c/attachment.htm>
More information about the Rpm-maint
mailing list