[Rpm-maint] [rpm-software-management/rpm] Implement a separate lock for the keystore (PR #4123)

Panu Matilainen notifications at github.com
Tue Apr 21 11:04:02 UTC 2026


@pmatilai commented on this pull request.



>  {
-    rpmts ts = rpmtxnTs(txn);
+    rpmtxn txn = ensureKxn(kxn, __func__);
+    rpmts ts = rpmtxnTs(kxn);

There's a kind of a point both ways I guess. But this made me realize ensureKxn() can fail, and so we need to check for a NULL return here. And that relates to why I wrote it this way, just didn't think it through entirely :smile: 

NULL-check added in the new version.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4123?email_source=notifications&email_token=ADLPZU7Z5EH2LIKLOT6KXKL4W5ISFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJUG4YTIMRVGUZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3116953019
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4123/review/4147142552 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260421/de7b6c4e/attachment.htm>


More information about the Rpm-maint mailing list