[Rpm-maint] [rpm-software-management/rpm] Implement a separate lock for the keystore (PR #4123)

[Michal Domonkos]

@dmnks commented on this pull request.



> @@ -370,15 +389,18 @@ rpmRC rpmtxnImportPubkey(rpmtxn txn, const unsigned char * pkt, size_t pktlen)
 
 exit:
     /* Clean up. */
+    if (txn != kxn)
+	rpmtxnEnd(txn);

Except... I've just realized that there's no such function as `rpmkxnEnd()`, oops :laughing:

But that makes me think - in `rpmtxnEnd()`, we release the `txn->lock` only (never the `krlock`). That seems... wrong. Hmm.

It's entirely possible that I'm just confused here, though :sweat_smile:

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4123?email_source=notifications&email_token=ADLPZU5QUZMDFJ24HAVA6VT4W6HKZA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJUHA4TCMJSGU22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3118556353
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4123/review/4148911255 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260421/637dba24/attachment.htm>