[Rpm-maint] [rpm-software-management/rpm] Implement a separate lock for the keystore (PR #4123)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -370,15 +389,18 @@ rpmRC rpmtxnImportPubkey(rpmtxn txn, const unsigned char * pkt, size_t pktlen)
 
 exit:
     /* Clean up. */
+    if (txn != kxn)
+	rpmtxnEnd(txn);

> But that makes me think - in rpmtxnEnd(), we release the txn->lock only (never the krlock). That seems... wrong. Hmm.

Oh, I misread this initially: `krlock` is a member of rpmts, not rpmtxn. I guess this could be seen as an argument for the ts_lock, txn_lock school of struct member naming.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4123?email_source=notifications&email_token=ADLPZU6M7XLXELS6CJ5J6LD4XBPATA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJVGI2DCNZSGE32M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3121907411
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4123/review/4152417217 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260421/2a90353d/attachment.htm>