[Rpm-maint] [rpm-software-management/rpm] Use git tags to determine RPM version strings (PR #4178)

[Michal Domonkos]

dmnks left a comment (rpm-software-management/rpm#4178)

Okay, let's recap. Using git tags to construct the version suffix has two advantages:

1. Allows us to avoid recording the pre-release label in two places (git tag *and* cmake)
2. Allows us to embed the git revision (commit count) into the version as well (for development snapshots)

In pre-release (or development) tarballs, we would just need to bundle another file (as you suggested), e.g. `VERSION`, that contains the version suffix generated at cmake configure time. That way, it's basically static in release tarballs, just not directly in the cmake config. For final releases, there would be no `VERSION` file and only the version from cmake would be used.

That said, I agree this split can be confusing and it just feels better to have it all in one place, in cmake. Looking at some other projects, though, systemd also has a separate version file...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4178?email_source=notifications&email_token=ADLPZU3HWEHC4TDOUCIWNUD4XB6YTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRZGQ3DQMRVHE3KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4294682596
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4178/c4294682596 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260422/4c64df24/attachment.htm>