[Rpm-maint] [rpm-software-management/rpm] RFC: Aligned payloads and reflinked payload file content (PR #4294)

coderabbitai[bot] notifications at github.com
Fri Aug 7 11:57:26 UTC 2026


@coderabbitai[bot] commented on this pull request.



> +    /* Plain streams use physical file offsets. Compressed streams align the
+     * canonical cpio relative to its decompressed start. */
+    if (fdIsPlain(fd)) {
+	off_t base = Ftell(fd);
+	cpio->base = (base > 0) ? base : 0;
+    }

`@daandemeyer`, this explanation appears to address a different test-coverage comment.

The finding here concerns `lib/cpio.cc`. It concerns the handling of `Ftell()` failure for a plain nonseekable payload stream. The direct-call and `runroot` test mix does not affect that alignment-base calculation.

<sub>You are interacting with an AI system.</sub>

<!-- This is an auto-generated reply by CodeRabbit -->

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4294#discussion_r3735577073
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4294/review/4882618816 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260807/eb528896/attachment-0001.htm>


More information about the Rpm-maint mailing list