[Rpm-maint] [rpm-software-management/rpm] Major cleanup of the rpmInstall() structures (PR #4073)

[Michal Domonkos]

@dmnks commented on this pull request.



> @@ -738,6 +738,130 @@ error: open of not_pkg.rpm failed: No such file or directory
 ])
 RPMTEST_CLEANUP
 
+RPMTEST_SETUP_RW([install from url])
+AT_KEYWORDS([install urlhelper manifest])
+AT_SKIP_IF([test -z "${PYTHON}"])
+
+# Startup a http server specific to this test group, serving from /data
+RPMTEST_CHECK([
+daemonize -o http.log -- ${PYTHON} -m http.server --bind 127.0.0.1 --directory /data

This is OK, just a couple of notes:

- How clever! 😄 
- The server will continue to run until the outer container exits, but it's not like that matters at all since it's a tiny daemon and won't interfere with any other tests
- This wouldn't scale if multiple test groups, which may run in parallel, were to use the server (or spawn its own), but that's also fine since we don't have any (and likely won't), and so no point in worrying about that here

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4073#pullrequestreview-3746309286
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4073/review/3746309286 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260203/fec6381d/attachment-0001.htm>