[Rpm-maint] [rpm-software-management/rpm] Major cleanup of the rpmInstall() structures (PR #4073)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -738,6 +738,130 @@ error: open of not_pkg.rpm failed: No such file or directory
 ])
 RPMTEST_CLEANUP
 
+RPMTEST_SETUP_RW([install from url])
+AT_KEYWORDS([install urlhelper manifest])
+AT_SKIP_IF([test -z "${PYTHON}"])
+
+# Startup a http server specific to this test group, serving from /data
+RPMTEST_CHECK([
+daemonize -o http.log -- ${PYTHON} -m http.server --bind 127.0.0.1 --directory /data

Oh indeed - *filesystem* is reset between tests, not the entire container, doh :sweat_smile: 

We do have some other tests that could use a http server as well, eg the urlhelper stuff in rpmgeneral.at that can only test failures currently.

daemonize does have options to ensure single instance, but then if we want it in multiple places I guess we should just have it running in the container at all times. Although that seems a bit silly for just a couple of tests as well.

Killing it at the end of the test-block isn't hard, I guess I'll just add that now, together with some comments about parallel tests etc.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4073#discussion_r2762824071
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4073/review/3749689688 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260204/786c3a3e/attachment.htm>