[Rpm-maint] [rpm-software-management/rpm] Major cleanup of the rpmInstall() structures (PR #4073)

[Michal Domonkos]

@dmnks commented on this pull request.



> @@ -738,6 +738,130 @@ error: open of not_pkg.rpm failed: No such file or directory
 ])
 RPMTEST_CLEANUP
 
+RPMTEST_SETUP_RW([install from url])
+AT_KEYWORDS([install urlhelper manifest])
+AT_SKIP_IF([test -z "${PYTHON}"])
+
+# Startup a http server specific to this test group, serving from /data
+RPMTEST_CHECK([
+daemonize -o http.log -- ${PYTHON} -m http.server --bind 127.0.0.1 --directory /data

> daemonize does have options to ensure single instance, but then if we want it in multiple places I guess we should just have it running in the container at all times. Although that seems a bit silly for just a couple of tests as well.

Yep, that'd also be an option, to run it from `atlocal` or perhaps the `RPMTEST_SETUP` macro in `local.at`. And if multiple tests happen to access it at the same time, that should be alright I guess, since they'd just be reading anyway.

> Killing it at the end of the test-block isn't hard, I guess I'll just add that now, together with some comments about parallel tests etc.

Ack, killing it won't hurt for sure :smile:

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4073#discussion_r2762866767
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4073/review/3749741385 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260204/b383cbec/attachment-0001.htm>