[Rpm-maint] [rpm-software-management/rpm] Major cleanup of the rpmInstall() structures (PR #4073)

[Michal Domonkos]

@dmnks commented on this pull request.



> +
+    switch (urlIsURL(fileURL)) {
+    case URL_IS_HTTPS:
+    case URL_IS_HTTP:
+    case URL_IS_FTP:
+	if (rpmIsVerbose())
+	    fprintf(stdout, _("Retrieving %s\n"), fileURL);
+
+	tfd = rpmMkTempFile(rpmtsRootDir(ts), &tfn);
+	if (tfn) {
+	    Fclose(tfd);
+	    rc = urlGetFile(fileURL, tfn);
+	    fn = tfn;
+	}
+	if (rc)
+	    rpmlog(RPMLOG_ERR, _("skipping %s - transfer failed\n"), fileURL);

> Pushed a new version with this, BUT then realized why it was written the way it was - if temp file creation succeeds then we'll need to cleanup the file, regardless of whether _retrieval_ succeeds.

Oh right, that *I* missed, for a change :laughing: 



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4073#discussion_r2763749442
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4073/review/3750763116 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260204/d891cd04/attachment.htm>