[Rpm-maint] [rpm-software-management/rpm] Fix delete_key_compat() friend definition (PR #4106)

[Michal Domonkos]

Commit e360ca338e5215a2015fef6ed843cfefd8463f2e mistakenly defined the function as static while also declaring it as a friend function in the keystore header file. While GCC didn't seem to mind, Clang failed with:

    error: static declaration of 'delete_key_compat' follows non-static
    declaration

And rightfully so. We just didn't notice since most of us build with GCC (including the CI), oops.

Fix by dropping the static keyword. This is fine because access control and visibility is handled by C++ here (since it's a friend function, not a standalone one), and the keystore API isn't public anyway.

Fixes: #4070
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/4106

-- Commit Summary --

  * Fix delete_key_compat() friend definition

-- File Changes --

    M lib/keystore.cc (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/4106.patch
https://github.com/rpm-software-management/rpm/pull/4106.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4106
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4106 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260205/c96dd478/attachment-0001.htm>