[Rpm-maint] [rpm-software-management/rpm] Add some cmake-presets(7) and test clang builds in CI (PR #4118)
Michal Domonkos
notifications at github.com
Thu Feb 19 08:39:43 UTC 2026
@dmnks commented on this pull request.
> @@ -69,6 +65,24 @@ RUN dnf -y install \
strace \
valgrind
+# Install the requested toolchain
+ARG TOOLCHAIN=gnu
+RUN case "$TOOLCHAIN" in \
+ gnu) \
True. The reason it's called "gnu" here is that `CMAKE_C_COMPILER_ID` [calls it](https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html) that way :smile: This PR uses that string to detect the toolchain used in the local cmake build (see `MKTREE_TOOLCHAIN` in tests/CMakeLists.txt).
We could of course "translate" that to "gcc" when seting `MKTREE_TOOLCHAIN`, and I'd agree that's a better name than "gnu".
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4118#discussion_r2826356481
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4118/review/3824206594 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260219/9dd59033/attachment.htm>
More information about the Rpm-maint
mailing list