[Rpm-maint] [rpm-software-management/rpm] Honor alternate root in system user/group provides (PR #4095)
Panu Matilainen
notifications at github.com
Thu Jan 22 14:40:44 UTC 2026
@pmatilai commented on this pull request.
> @@ -672,6 +673,8 @@ static int systemProvides(rpmts ts, rpmds dep)
size_t nlen = strlen(n);
char *dval = NULL;
+ rpmChrootSet(rpmtsRootDir(ts));
I'd move these rpmChrootSet()'s to rpmtsCheck() level so they only get called once per the full dependency checking round. systemProvides() gets called once for every non-rpmlib() dependency which can be (tens of) thousands times.
Other than that, seems fine to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4095#pullrequestreview-3692801974
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4095/review/3692801974 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260122/9f2e0750/attachment.htm>
More information about the Rpm-maint
mailing list