[Rpm-maint] [rpm-software-management/rpm] Throw OSError: Invalid argument Error if rpm.fd mode string is not valid (PR #4128)
El Autentico
notifications at github.com
Tue Mar 3 23:07:10 UTC 2026
elcanario922 left a comment (rpm-software-management/rpm#4128)
Thanks @pmatilai, I hope the fix covers all edge cases... I removed `fpio` from test 106 because, as with the old bug, `fpio` was silently falling back to `fdio` after the fix (leading to OSError). I think it’s fine to leave test 107 to specifically validate the "OSError" case. I think keeping them separate is better (since we only want to check for `findIOT` NULL pointer, thats why as well I did not added more iot's to it....
Also, there might be a better way to handle this than using a raw file descriptor to check the IO engine, but I find it clean to separate the descriptor allocation (`fdOpen` vs `ufdOpen`) and then open the stream via `Fdopen`, reassigning to `fd`.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4128#issuecomment-3994122872
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4128/c3994122872 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260303/5153f92f/attachment.htm>
More information about the Rpm-maint
mailing list