[Rpm-maint] [rpm-software-management/rpm] Fix rpm --undefine and Lua rpm.undefine() bypassing sanity checks (PR #4135)

Michal Domonkos notifications at github.com
Thu Mar 12 17:23:32 UTC 2026


@dmnks requested changes on this pull request.

LGTM, other than the nit below.

> @@ -58,6 +58,7 @@ public:
     /* Copy all macros from this context to another one */
     void copy(rpm::macros & dest, int level);
     int define(const std::string & macro, int level);
+    int undefine(const std::string & n);

This addition is in the wrong commit (should be in the middle one).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4135#pullrequestreview-3938381958
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4135/review/3938381958 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260312/d9908e73/attachment-0001.htm>


More information about the Rpm-maint mailing list