[Rpm-maint] [rpm-software-management/rpm] Implement a separate lock for the keystore (PR #4123)

Panu Matilainen notifications at github.com
Wed Mar 18 12:16:21 UTC 2026


@pmatilai commented on this pull request.



> @@ -1127,6 +1129,22 @@ rpmtxn rpmtxnBegin(rpmts ts, rpmtxnFlags flags)
     return txn;
 }
 
+#define RPMLOCK_PATH LOCALSTATEDIR "/rpm/.rpm.lock"
+rpmtxn rpmtxnBegin(rpmts ts, rpmtxnFlags flags)
+{
+    static const char * const rpmlock_path_default = "%{?_rpmlock_path}";
+    return rpmtxnCreate(ts, flags, rpmlock_path_default, RPMLOCK_PATH,
+			_("transaction"), &(ts->lock));
+}
+
+#define KSLOCK_PATH LOCALSTATEDIR "/rpm/.keyring.lock"
+rpmtxn rpmkxnBegin(rpmts ts, rpmtxnFlags flags)
+{
+    static const char * const kslock_path_default = "%{?_keyring_lockpath}";

I'd keep the "keyring" in the name because .. that's what it is for. That "rpmlock_path" is named like there shall only be One Lock can't be helped :sweat_smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4123#discussion_r2953043586
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4123/review/3967391789 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260318/061b10b0/attachment-0001.htm>


More information about the Rpm-maint mailing list