[Rpm-maint] [rpm-software-management/rpm] Implement a separate lock for the keystore (PR #4123)

Panu Matilainen notifications at github.com
Wed Mar 18 12:24:04 UTC 2026


@pmatilai commented on this pull request.



> @@ -597,6 +597,7 @@ rpmts rpmtsFree(rpmts ts)
     }
     ts->rootDir = _free(ts->rootDir);
     rpmtsLockFree(ts);

Argh, that. There was a reason for it to be in a function because it originally had two free()'s in it and called from two separate places.

IIRC I left it alone because we might want to also free the kslock from two places (so we might move the kslock free into rpmtsLockFree()) - the other being rpmtsRebuildDB to recreate the lock file so regular users can do it. But that bit got lost in the other hand-wringing around this thing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4123#discussion_r2953084082
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4123/review/3967434144 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260318/ee72259c/attachment.htm>


More information about the Rpm-maint mailing list