[Rpm-maint] [rpm-software-management/rpm] Implement a separate lock for the keystore (PR #4123)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -597,6 +597,7 @@ rpmts rpmtsFree(rpmts ts)
     }
     ts->rootDir = _free(ts->rootDir);
     rpmtsLockFree(ts);

Actually, let's not :sweat_smile: 

I started saying that I'll add the lockfile recreation in there, otherwise this would reintroduce https://github.com/rpm-software-management/rpm/issues/3886 as a regression. But while looking for that ticket I realized that with this change, we no longer need to recreate the *transaction* lockfile, because transactions are only ever performed by root. #3886 was always about queries now requiring that lock. And with this PR, the lock that needs to be there is instead the keyring lock!

Good thing you brought this up, even if it just seemed more like a cosmetic thing. Quite possibly the above realization makes the whole thing feel a little bit less wrong.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4123#discussion_r2973388280
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4123/review/3989886475 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260323/09151fbb/attachment.htm>