[Rpm-maint] [rpm-software-management/rpm] Add support for defining literal macros via a new modifier syntax (PR #4129)

[Panu Matilainen]

@pmatilai commented on this pull request.



>      if (*s == '(') {
 	s++;	/* skip ( */
 	/* Options must be terminated with ')' */
 	if (strchr(s, ')')) {
-	    o = oe;
-	    COPYOPTS(oe, s, oc);
+	    int oc = ')';
+	    COPYOPTS(opts, s, oc);
+	    o = opts.c_str();

It wont work. Empty string passed as opts to pushMacro() still creates a parametric macro, it needs to be NULL for regular macros. It is ugly and inconsistent for sure. I looked at making parametric macros a flag instead, but that hole goes surprisingly deep, I got some rather mysterious results.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4129#discussion_r2975030501
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4129/review/3991720380 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260323/67fdf7c5/attachment.htm>