[Rpm-maint] [rpm-software-management/rpm] Add support for defining literal macros via a new modifier syntax (PR #4129)
Michal Domonkos
notifications at github.com
Mon Mar 23 13:34:58 UTC 2026
@dmnks commented on this pull request.
> } else if (c == '{') { /* XXX permit silent {...} grouping */
if ((se = matchchar(s, c, '}')) == NULL) {
rpmMacroBufErr(mb, 1, _("Macro %%%s has unterminated body\n"), n);
se = s; /* XXX W2DO? */
goto exit;
}
s++; /* XXX skip { */
- strncpy(b, s, (se - 1 - s));
- b[se - 1 - s] = '\0';
- be += strlen(b);
+ body = str.substr(s - se, (se - 1 - s));
Ack, so let's add a test in this PR (if it's not too complicated)...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4129#discussion_r2975073091
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4129/review/3991768769 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260323/ea30c0fb/attachment.htm>
More information about the Rpm-maint
mailing list