[Rpm-maint] [rpm-software-management/rpm] Add support for defining literal macros via a new modifier syntax (PR #4129)

Panu Matilainen notifications at github.com
Mon Mar 23 14:28:40 UTC 2026


@pmatilai commented on this pull request.



>      if (*s == '(') {
 	s++;	/* skip ( */
 	/* Options must be terminated with ')' */
 	if (strchr(s, ')')) {
-	    o = oe;
-	    COPYOPTS(oe, s, oc);
+	    int oc = ')';
+	    COPYOPTS(opts, s, oc);
+	    o = opts.c_str();

Might be worth a comment in the code, it isn't the most obvious thing with the surrounding C++ stuff.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4129#discussion_r2975409566
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4129/review/3992178364 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20260323/d709f760/attachment.htm>


More information about the Rpm-maint mailing list